Skip to content

Tabs: on refresh, cannot find that it is in a nested state #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ajoslin opened this issue Mar 25, 2014 · 6 comments
Closed

Tabs: on refresh, cannot find that it is in a nested state #894

ajoslin opened this issue Mar 25, 2014 · 6 comments
Assignees
Milestone

Comments

@ajoslin
Copy link
Contributor

ajoslin commented Mar 25, 2014

While on one hand, we don't "officially" say we support the browser, this would be good to have. If it's not too hard, scheduling for beta.2

related: #879

@ajoslin ajoslin added this to the 1.0.0-beta.2 milestone Mar 25, 2014
@ajoslin ajoslin self-assigned this Mar 25, 2014
@rvanbaalen
Copy link

This can be related to my comment in #879:

@ajoslin I've been looking into this and you guys are using $state.current an awful lot in the Ionic code. But I think this has been refactored to $state.$current which contains a lot more data (like $state.$current.views, which you are using to verify the current tab view).

ajoslin added a commit that referenced this issue Apr 1, 2014
@ajoslin
Copy link
Contributor Author

ajoslin commented Apr 1, 2014

I think I fixed it! @rvanbaalen! Could you give the nightly build a try with the fix I just pushed?

@rvanbaalen
Copy link

Awesome news @ajoslin. But unfortunately I worked around the issue in my current app so I don't have a working use case set-up to test the new code. I'll give it a shot later today.

@ajoslin
Copy link
Contributor Author

ajoslin commented Apr 1, 2014

If you're able to that'd be great. Thanks @rvanbaalen !

@ajoslin
Copy link
Contributor Author

ajoslin commented Apr 8, 2014

Closing as fixed!

@ajoslin ajoslin closed this as completed Apr 8, 2014
@ionitron-bot
Copy link

ionitron-bot bot commented Sep 6, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants