Skip to content

chore(git): improve Ionitron to stop closing issues that have the 'needs: investigation' label #30424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

gnbm
Copy link
Contributor

@gnbm gnbm commented May 25, 2025

Issue number: internal


What is the current behavior?

  • Currently, Ionitron is closing issues when they have the needs: investigation label.
  • We might want to use the duplicate ticket as our source of truth since a community member has made a suggestion that could fix it.

What is the new behavior?

  • The ionic-issue-bot.yml file was changed to stop closing issues that have the needs: investigation label
  • To prevent Ionitron from closing issues with the needs: investigation label, we've added this label to the exemptLabels list under the stale, noReply, and noReproduction sections.
  • This tells the bot not to close issues with that label, even if they meet the criteria for being stale or lacking a reply/reproduction.

Does this introduce a breaking change?

  • Yes
  • No

Other information

  • N.A.

@gnbm gnbm requested a review from a team as a code owner May 25, 2025 14:37
@gnbm gnbm added the package: core @ionic/core package label May 25, 2025
@gnbm gnbm requested a review from christian-bromann May 25, 2025 14:37
Copy link

vercel bot commented May 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 25, 2025 2:37pm

@github-actions github-actions bot removed the package: core @ionic/core package label May 25, 2025
@gnbm gnbm changed the title chore(): improve Ionitron to stop closing issues that have the 'needs: investigation' label chore(git): improve Ionitron to stop closing issues that have the 'needs: investigation' label May 25, 2025
@gnbm gnbm added the type: feature request a new feature, enhancement, or improvement label May 25, 2025
Comment on lines +117 to +118
exemptLabels:
- "needs: investigation"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
exemptLabels:
- "needs: investigation"

This isn't needed because the issue is only closed if it has needs: reply and we don't add that to investigative tickets

Comment on lines +137 to +138
exemptLabels:
- "needs: investigation"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
exemptLabels:
- "needs: investigation"

This isn't needed because the issue is only closed if it has ionitron: needs reproduction and we don't add that to investigative tickets

@brandyscarney brandyscarney removed the type: feature request a new feature, enhancement, or improvement label May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants