fix: fixed the nested tabs selected, initialize property $tabSelected. #3157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elected. Like the issue #1276 if you have some nested tabs, you select a sub-tab item, and you will active some other siblings, because when tabCtrl add every new $scope, it does't has a initial attr $scope.$tabSelected, so every unselected item will read the $tabSelected from inherited $parent, but if the parent-tab has been actived, the all of its sub-tabs will read this true property in $scope.$tabSelected. So I think we should initialize the property $scope.$tabSelected before invoking tabsCtrl.add(), and every tab-item will has a 'false' status for a initial $scope.$tabSelected.
In general a element, it is available to use the directive nav-direction, but in directive ion-item, it will build an anchor element by its template ITEM_TPL_CONTENT_ANCHOR, it doesn't has the nav-direction attribute, so I updated the ITEM_TPL_CONTENT_ANCHOR and add a proxy function $navDirection in directive ion-item.
This reverts commit b07c007.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like the issue #1276
if you have some nested tabs, you select a sub-tab item, and you will
active some other siblings, because when tabCtrl add every new $scope,
it does't has a initial attr $scope.$tabSelected, so every
unselected item will read the $tabSelected from inherited
$parent, but if the parent-tab has been actived, the all of its
sub-tabs will read this true property in $scope.$tabSelected.
So I think we should initialize the property $scope.$tabSelected before
invoking tabsCtrl.add(), and every tab-item will has a 'false' status
for a initial $scope.$tabSelected.