Disable $animate animations to allow correct count of slides

[rossholdway]

Fixes issues #3646 and #3076. $animate was delaying the removal of elements. Therefore when the slide-box child elements were counted the reported length would be inaccurate.

Thanks,
Ross

[bis27]

Hi rossholdway,

When will this fix be available in nightly build and in official baseline?

[bis27]

Hi,

I tried the CSS fix in the demo code present at https://github.com/bis27/ionic-slide-box-crash but I still see the crash on rotation.

[rossholdway]

Hi @bis27

I think you have confused this pull request with another issue. This fixes an issue related to the number of slides being incorrectly counted.

[hui]

@gravitywp will this fix our issue?

[bis27]

Hi @rossholdway,
Can you please point to me the changes done for #3722? Or is it still open?

Thanks!

[rossholdway]

@bis27 Unfortunately it looks like the issue your talking about has not been fully resolved yet, so it's still open.

[bis27]

@rossholdway Sorry to bug you, is there any plan to look into issue #3722?

I have put a sample code at https://github.com/bis27/ionic-slide-box-crash which shows the crash on the latest ionic version v1.0.0 on iPad 3 and iPad Air as soon as we rotate the device !

In our actual product, we are creating ionic slide-boxes dynamically with 3-5 ion-slides by selecting some options from a side-menu. Each ion-slide item has either an ng-repeat or a collection-repeat or an iframe drawing a chart on canvas. Once the data set increases, the app simply crashes on rotation or when we are inside a slide-box and trying to delete the existing one and create a new one (by clicking our app's side-menu options)

Such crashes are not noted on lower screen-size devices like iPhone and iPad Mini. Hence the app behaves fine on these devices but simply crashes on iPad3/Air

It looks like ionic slide-box is using a lot of memory internally and may also be trigering invalid memory access.

[rossholdway]

@bis27 I'm not sure if anyone is planning to look into this. The issue is tagged for milestone 1.0.1 though!

[vicheanak]

Come on boy! Let's fix this! Ionic wasn't that good quality as it claimed to be, poor team.

[rossholdway]

@perrygovier Any idea what happened to this? It did not make it into 1.0.1 so the bug is still present ! Can we reassign to 1.0.2?

[mhartington]

Thanks! Merged via 98ccc9d