Prevent click events from firing twice on Windows Phone #4638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlynch
added a commit
that referenced
this pull request
Dec 6, 2015
Prevent click events from firing twice on Windows Phone
|
+1 |
|
I discoverd that by this bug fix (thank you for that ;-)) the "activated" class does not apply on the appropriated html elements on windows... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows Phone 8.1 and 10, Ionic (1.1.1) invokes click events twice in certain situations (caused by the tap handler). This patch filters out these events on the affected element types.
Note: I recognise that Windows Phone is not currently officially supported. However, this is literally the only issue I've encountered when targeting Windows Phone - which is pretty good going for an unsupported platform.