Ios portals 0.6.1 #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(react-native, ios): Addresses issue where setting initial context for a specific PortalView does not update initial context for all portals
Steven0351
commented
Jun 3, 2022
| } | ||
|
|
||
| @objc static func requiresMainQueueSetup() -> Bool { true } | ||
| } | ||
|
|
||
| @objc(IONPortalsPubSub) | ||
| @objc(IONPortalPubSub) |
There was a problem hiding this comment.
This needed to be renamed to not clash with IonicPortals.IONPortalsPubSub
Steven0351
commented
Jun 3, 2022
| @@ -56,7 +56,7 @@ class PortalManagerModule(reactContext: ReactApplicationContext) : | |||
| class PortalsPubSubModule(reactContext: ReactApplicationContext) : | |||
| ReactContextBaseJavaModule(reactContext) { | |||
| override fun getName(): String { | |||
| return "IONPortalsPubSub" | |||
| return "IONPortalPubSub" | |||
There was a problem hiding this comment.
This needed to be renamed to match iOS
native application.
have `@objc` annotation
giralte-ionic
approved these changes
Jun 3, 2022
carlpoole
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.