-
Notifications
You must be signed in to change notification settings - Fork 9
Pub sub fix #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pub sub fix #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix the Github Lint warnings as I assume != and !== mean two different things
Well, looks like at some point i'm going to make the linter error on warnings. They are different though I'm not sure it really matters when checking against undefined. The difference is != will coerce and !== will not coerce. |
@@ -11,7 +11,7 @@ | |||
"format": "prettier App.tsx -w" | |||
}, | |||
"dependencies": { | |||
"@ionic/portals-react-native": "^0.0.1", | |||
"@ionic/portals-react-native": "file:../ionic-portals-react-native-0.0.1.tgz", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this intended to replace with a local zip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for now yes, there are instructions in the example README on how to generate it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My intention is to reconfigure the project to have a monorepo structure where the example project is not a subfolder of the library itself. This was causing weird issues where the example project was also in node_modules when just doing "@ionic/portals-react-native": "file:../"
, and the npm pack thing was done to prevent all that
Addresses issue with subscribers receiving all messages for all topics