Skip to content

Pub sub fix #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 1, 2022
Merged

Pub sub fix #9

merged 5 commits into from
Jun 1, 2022

Conversation

Steven0351
Copy link
Contributor

Addresses issue with subscribers receiving all messages for all topics

Copy link

@giralte-ionic giralte-ionic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the Github Lint warnings as I assume != and !== mean two different things

@Steven0351
Copy link
Contributor Author

please fix the Github Lint warnings as I assume != and !== mean two different things

Well, looks like at some point i'm going to make the linter error on warnings. They are different though I'm not sure it really matters when checking against undefined. The difference is != will coerce and !== will not coerce.

@@ -11,7 +11,7 @@
"format": "prettier App.tsx -w"
},
"dependencies": {
"@ionic/portals-react-native": "^0.0.1",
"@ionic/portals-react-native": "file:../ionic-portals-react-native-0.0.1.tgz",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this intended to replace with a local zip

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for now yes, there are instructions in the example README on how to generate it.

Copy link
Contributor Author

@Steven0351 Steven0351 Jun 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My intention is to reconfigure the project to have a monorepo structure where the example project is not a subfolder of the library itself. This was causing weird issues where the example project was also in node_modules when just doing "@ionic/portals-react-native": "file:../", and the npm pack thing was done to prevent all that

@Steven0351 Steven0351 merged commit c621efc into main Jun 1, 2022
@Steven0351 Steven0351 deleted the pub-sub-fix branch June 1, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants