feat(icon): expose 'icon-inner' and 'svg' as shadow parts #1027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also - add usage examples to index.html - update icon readme
Juarrow
force-pushed
the
960_shadow-part_inner
branch
from
0c54b3a to
b572c8d
Compare
Juarrow
changed the title
|
@Juarrow thanks for raising this PR. I am a bit concerned about the way we tweak the DOM through direct DOM writes instead of relying on the shadow DOM. Why can't we just make the following change: - <div class="icon-inner" innerHTML={this.svgContent}></div>
+ <div class="icon-inner" part="inner-icon" innerHTML={this.svgContent}></div>? |
|
It's been ~3.5 years and I don't use Ionic anymore. (And there probably have been many changes to Ionic itself, I guess - so no clue if this MR is still up-to-date enough.) If you want you may close it, update it or just use it as inspiration. |
|
Thanks for the response, I will go ahead and close this. Happy to re-open anytime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #960
.icon-innerand the SVG element as shadow parts ```::part(icon-inner)&::part(svg)``index.htmlicon/readme.md(To be honest: this feels kind of hacky to me, so i opened this for discussion. Sorry for the inconvenience - if it causes any.)