fix(icon): add fallback for safari 16.4 #1222
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safari 16.4 has a bug where dynamically changing the document
dirfor the first time does not cause styles that use:dirto update. This new fallback allows icons to still flip correctly in the event the documentdirchanges before the component loads. If the documentdirchanges again, then Safari/WebKit will correctly re-render.WebKit bug: https://bugs.webkit.org/show_bug.cgi?id=257133
This WebKit bug is causing visual diffs in Ionic Framework with screenshots with
ion-back-buttonbecause adding?rtl=trueto the URL causes the testing scripts to update the documentdirasynchronously: ionic-team/ionic-framework@df7af96This behavior should not impact applications that start with the desired document
dir. This would impact applications that change the documentdirdynamically. However, even before this fix developers would have encountered #1196 with theion-back-buttonso there would have been no visual change.