This repository was archived by the owner on Jan 13, 2023. It is now read-only.
docs: Add 'Fetch Data' tutorial #289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
todofixthis
approved these changes
Jan 16, 2020
examples/tutorials/03_fetch_data.py
Outdated
Comment on lines
25
to
28
| data = tx.signature_message_fragment.decode() | ||
| # Ignore invalid or not unicode encoded data | ||
| except (TrytesDecodeError, UnicodeDecodeError): | ||
| continue |
There was a problem hiding this comment.
I think we can achieve basically the same result with:
data = tx.signature_message_fragment.decode(errors='ignore')More info:
https://github.com/iotaledger/iota.py/blob/2.1.0/iota/types.py#L536-L547
(this is meant to mimic the way Python's codecs.decode() function works)
There was a problem hiding this comment.
You are right, however, with ignore, only the values that can't be decoded are dropped, the rest of the non-meaningful message will be printed.
Anyway, I added a small explanation and changed it to your suggestion.
- Introduce numbering in headings too.
lzpap
force-pushed
the
fetch_data_tutorial
branch
from
d04a8d2 to
c48d874
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #268 and #284
Description
Fetch Datatutorial to gather messages from the Tangle.