Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

chore: fix CI workflows #527

Merged
merged 19 commits into from
Oct 14, 2022
Merged

chore: fix CI workflows #527

merged 19 commits into from
Oct 14, 2022

Conversation

SgtPooki
Copy link
Collaborator

@SgtPooki SgtPooki commented Oct 13, 2022 •
edited
Loading

testing to see if changes in #517 break CI workflows, or if they're already broken

They were broken. This PR fixes them and is blocking #517

@SgtPooki
chore: tmp
13cb390 
testing to see if changes in ipfs-examples#517 break CI workflows, or if they're already broken
@SgtPooki
chore: attempt to fix ci runs
0e3d4ff 
see https://playwright.dev/docs/cli\#install-system-dependencies
@SgtPooki
fix: github workflow syntax
fa6966a
@SgtPooki
chore: ensure concurrency on branch name
04aa2a3
@SgtPooki
chore: update actions
f74edb8
@SgtPooki
fix: don't fail-fast for matrix failures
48be6dc
@SgtPooki
chore: attempt to remove GabrielBB/xvfb-action
a63e42b 
some steps are showing the following failure on github:
Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: GabrielBB/xvfb-action

see https://github.com/SgtPooki/js-ipfs-examples/actions/runs/3245100955
@SgtPooki
chore: remove gabriel/xvfb-action for good
5afb73d
@SgtPooki
chore: add xvfb-maybe to run-in-electron
a7f6c97
@SgtPooki
Copy link
Collaborator Author

Making significant progress with CI improvements, see https://github.com/SgtPooki/js-ipfs-examples/actions/runs/3245177404/jobs/5322363884 where all tests except monorepo, run-in-electron and browser-service-worker all succeeded

@SgtPooki
Copy link
Collaborator Author

fixed run-in-electron, see https://github.com/SgtPooki/js-ipfs-examples/actions/runs/3245277233/jobs/5322594464

@SgtPooki SgtPooki changed the title chore: tmp chore: fix CI workflows Oct 13, 2022
@SgtPooki
Copy link
Collaborator Author

SgtPooki commented Oct 13, 2022 •
edited
Loading

hopefully fixed browser-service-worker by resolving error in lib/test-util-ipfs-example/playwright/servers.js where server promises(promiseServers), that were awaited, await Promise.all(promiseServers), were being overwritten when stopping the servers (fix at 2c99e77). I believe this was causing the race condition we were seeing in github CI and not locally.

https://github.com/SgtPooki/js-ipfs-examples/actions/runs/3245576932/jobs/5323287852

@SgtPooki
Copy link
Collaborator Author

Previous fix was not successful.. server is quitting prior to second page.goto request.. will be playing around with this. https://github.com/SgtPooki/js-ipfs-examples/actions/runs/3245623910 now

@SgtPooki
Copy link
Collaborator Author

attempting to increase timeout for the failing test: https://github.com/SgtPooki/js-ipfs-examples/actions/runs/3246023082

@SgtPooki
Copy link
Collaborator Author

Noticed that we were calling server.close instead of server.stop, and stoppable doesn't wait for requests to end if close is used. Hopefully switching to server.stop resolves the race condition: https://github.com/SgtPooki/js-ipfs-examples/actions/runs/3246253813/jobs/5324789350

@SgtPooki
Copy link
Collaborator Author

@hugomrdias @achingbrain any insight you two have for this service worker example failing in CI but not locally? I’ve been diving through playwright docs trying to figure out whats going on and haven’t made much progress.

@SgtPooki
Copy link
Collaborator Author

SgtPooki commented Oct 14, 2022 •
edited
Loading

finally getting somewhere: https://github.com/SgtPooki/js-ipfs-examples/actions/runs/3251274740/jobs/5336053592#step:6:93

requestfailed: http://localhost:3000/view/ipfs/Qmf412jQZiuVUtdgnB36FXFX7xg5V6KEbSJ4dpQuhkLyfD

@SgtPooki
Copy link
Collaborator Author

seems to be aborting the network request. https://github.com/SgtPooki/js-ipfs-examples/actions/runs/3251450530/jobs/5336452807#step:6:83, increasing timeout to see if things resolve within a larger timeframe

@SgtPooki
Copy link
Collaborator Author

SgtPooki commented Oct 14, 2022 •
edited
Loading

resolved the issues by removing the dependence on the iframe entirely as that seems to cause issues with playwright in the github CI. see https://github.com/SgtPooki/js-ipfs-examples/actions/runs/3251560808 for the success.

using npm run build && PWDEBUG=1 playwright test tests --debug we can see that the response does come from the service worker:

image

@SgtPooki
fix(test-util-ipfs-example.servers): allow server stop from tests
bcbc1d8 
remove waitForSelectors and ensure service worker response is done before checking for text

debugging: query /view directly

this removes the need for playwright navigating iframes and still utilizes the serviceWorker in the test
@SgtPooki
chore: cleanup browser-service-worker test
be687b9
@SgtPooki
Revert "chore(tmp): disable all but browser-service-worker tests"
dd0067e 
This reverts commit 76a94cc.
@SgtPooki SgtPooki marked this pull request as ready for review October 14, 2022 17:24
@SgtPooki
Copy link
Collaborator Author

All workflows succeeding again, https://github.com/ipfs-examples/js-ipfs-examples/actions/runs/3251647631/jobs/5336920657, @hugomrdias @achingbrain.

@SgtPooki SgtPooki merged commit 49250ad into ipfs-examples:master Oct 14, 2022
@SgtPooki SgtPooki deleted the test-pr-workflows branch October 14, 2022 18:22
@SgtPooki
Copy link
Collaborator Author

merging because this is essential to unblock kubo-rpc-client, and CI is passing, a lot of work done here and this is a QOL improvement

@SgtPooki SgtPooki mentioned this pull request Oct 14, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@achingbrain achingbrain Awaiting requested review from achingbrain

@hugomrdias hugomrdias Awaiting requested review from hugomrdias

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SgtPooki