Skip to content
This repository was archived by the owner on Mar 10, 2020. It is now read-only.

feat: add support for custom headers to send-request #741

Merged
merged 6 commits into from
Jun 18, 2018
Merged

feat: add support for custom headers to send-request #741

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4ebb2e0
add support for custom headers to send-request
Apr 15, 2018
d8301a5
add custom headers test
Apr 15, 2018
7757d1a
add custom headers test
Apr 24, 2018
9311394
add custom header documentation
Apr 26, 2018
ee4368b
Merge branch 'master' into feat/custom-headers
May 3, 2018
cf96cee
fix: clone config.headers to avoid prev headers in next req
alanshaw Jun 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/utils/send-request.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ function requestAPI (config, options, callback) {
delete options.qs.followSymlinks

const method = 'POST'
const headers = {}
const headers = config.headers || {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need an Object.assign({}, config.headers) to avoid mutating the headers object passed as config, otherwise subsequent requests will receive the same headers as previous.


if (isNode) {
// Browsers do not allow you to modify the user agent
Expand Down