This repository was archived by the owner on Mar 10, 2020. It is now read-only.
fix(util): addFromURL with URL-escaped file names #764
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves double-URL-escaping problem happening when already escaped filename is added to IPFS via
ipfs.util.addFromURL
withwrap-with-directory=true
.(Originally issue found while working on ipfs/ipfs-companion#349)
How to reproduce
Current behavior
Wrapping directory contains URL-escaped file name:
Expected behavior
Wrapping directory should list file under original name: