Skip to content
This repository was archived by the owner on Aug 12, 2020. It is now read-only.

Setup dignified.js #13

Merged
merged 2 commits into from
Apr 11, 2016
Merged

Setup dignified.js #13

merged 2 commits into from
Apr 11, 2016

Conversation

dignifiedquire
Copy link
Contributor

At the moment tests are failing in phantomjs, no idea why. cc @nginnever @diasdavid

Ref ipfs/aegir#1

@daviddias
Copy link
Contributor

@dignifiedquire could you rebase master onto your PR? We've now 100% green on master, thanks to @noffle's finding

@dignifiedquire
Copy link
Contributor Author

@diasdavid done

@daviddias
Copy link
Contributor

@dignifiedquire I was rebasing master onto this branch and found that tests error on PhantomJS run:

  1) IPFS data importing tests on the Browser layout: importer import a big buffer:
     AssertionError: expected 1311038 to equal 1258318 (/Users/ground-control/code/protocol-labs/_ipfs/js/js-ipfs-data-importing/test/browser.js:45552)

Do you also see this in your machine?

//cc @nginnever

@nginnever
Copy link
Contributor

I just pulled this PR and wasn't able to repro the PhantomJS error.

@daviddias daviddias merged commit ab15916 into master Apr 11, 2016
@daviddias daviddias deleted the dignified branch April 11, 2016 21:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants