Skip to content

Vue3 migrate #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 252 commits into from
Jul 28, 2022
Merged

Vue3 migrate #214

merged 252 commits into from
Jul 28, 2022

Conversation

femans
Copy link
Contributor

@femans femans commented Jun 27, 2022

This migrates to vue3, vuetify3Beta, vuex4, Vite, Vitest, TS support, prettier
Fixing #125 and #124

Cycled in extra features:

@femans
Copy link
Contributor Author

femans commented Jul 26, 2022

(reply to @Szeket review):
to summarize:

  • footer covers bottom results < the footer appears if you scroll up, even 1px is enough. it dissappears if you scroll down. If this is not the case, please let me know all the details. I have tried with the same browser and the same query as you did.
  • Most files don't work in the audio player. Something to make an issue report out of, unless the behavior is different than previously
  • NSFW-errors and nsfw classification not available - should be fixed

@dokterbob
Copy link
Member

@femans I really would prefer not to have these code climate issues here. It doesn't imply we need to do what CodeClimate says, but I'd rather not get 71 issue notifications something isn't much alright.

Would it be possible for you to suggest some workaround (e.g. disable eslint in CodeClimate)?

@femans
Copy link
Contributor Author

femans commented Jul 28, 2022

@femans I really would prefer not to have these code climate issues here. It doesn't imply we need to do what CodeClimate says, but I'd rather not get 71 issue notifications something isn't much alright.

Would it be possible for you to suggest some workaround (e.g. disable eslint in CodeClimate)?

@dokterbob couple of things; 1, I would rather not have 70 issues either, but if these are the same issue and the issue is nonsense, I will not stop this from deploying. 2, Great idea to remove the eslint check! I did this, but remember that we wil need to add to the CI pipeline npm run lint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants