feat: create js-pinning-service-http-client #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
SgtPooki
commented
Mar 1, 2022
•
SgtPooki
commented
lidel
changed the title
lidel
force-pushed
the
feature/initial-release
branch
from
8c46285 to
0c7703c
Compare
decrease noise, just test LTS for now
lidel
force-pushed
the
feature/initial-release
branch
from
0c7703c to
5ce2a5a
Compare
lidel
requested changes
Mar 1, 2022
There was a problem hiding this comment.
- I pushed small tweak to decrease CI noise
- it seems that the current error is not related to CI: I get the same
MODULE_NOT_FOUNDerror when i runnpm i && npm run buildlocally - windows build will remain broken unless you replace
.shscripts with.jsones- i think it is acceptable to remove windows target from CI for now (can be fixed/added later)
- I am confused why we have duplicated
js-test-and-release.ymlandtest-and-release.ymlwe most likely want to merge them into one
removed shell scripts fixed manipulation of tsc with tsc-silent, and instead call tsc-silent directly for the generated source
is a pain
lidel
force-pushed
the
feature/initial-release
branch
from
1402c53 to
a0ebdd6
Compare
lidel
approved these changes
Mar 17, 2022
There was a problem hiding this comment.
Thanks! LGTM, I've pushed some changes to README.md.
Ok to merge this, but before we ship it to NPM, we need to tweak publicly exported names.
I think we could do that in src/index.ts and leave generated code as-is (details inline).
Up to you to decide if you want to rename in this PR or a separate one.
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.