-
Notifications
You must be signed in to change notification settings - Fork 6
add a utility method for sorting CID slices #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
package cidutil | ||
|
||
import ( | ||
"github.com/ipfs/go-cid" | ||
"sort" | ||
) | ||
|
||
// Slice is a convenience type for sorting CIDs | ||
type Slice []cid.Cid | ||
|
||
func (s Slice) Len() int { | ||
return len(s) | ||
} | ||
|
||
func (s Slice) Less(i, j int) bool { | ||
return s[i].KeyString() < s[j].KeyString() | ||
} | ||
|
||
func (s Slice) Swap(i, j int) { | ||
s[i], s[j] = s[j], s[i] | ||
} | ||
|
||
func (s Slice) Sort() { | ||
sort.Sort(s) | ||
} | ||
|
||
// Sort sorts a slice of CIDs | ||
func Sort(s []cid.Cid) { | ||
Slice(s).Sort() | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not wrap either
sort.Slice
orsort.SliceStable
and then theSlice
type isn't required?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sort.Slice
uses reflection so it's not quite as fast. It may not make a difference but it's not exactly a ton of code.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, this may just be me having an aversion to named slice types more than anything else :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well... when go introduces proper generics all this stuff will magically disappear. Until then, we have hand-coded monomorphization.
😞