Skip to content

Remove protobuf protocol #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 25, 2022
Merged

Remove protobuf protocol #385

merged 3 commits into from
Jun 25, 2022

Conversation

hannahhoward
Copy link
Collaborator

Goals

Remove protobuf protocol for next Lotus release

Implementation

Remove all protobuf code -- I think I got it all

  • had to make a minor change in benchmarks
  • left infra in place to support multiple protocol versions, as that's something we're likely to want.

@hannahhoward hannahhoward force-pushed the chore/deprecate-protobuf-protocol branch from 8d89133 to c3a0b16 Compare June 13, 2022 17:13
@hannahhoward
chore(message): remove protobuf protocol
ea32aae 
Remove all support for the protobuf protocol
@hannahhoward hannahhoward force-pushed the chore/deprecate-protobuf-protocol branch from c3a0b16 to ea32aae Compare June 13, 2022 19:05
rvagg
rvagg approved these changes Jun 14, 2022
View reviewed changes
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok 🤞

@hannahhoward hannahhoward merged commit 35ac375 into main Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvagg rvagg rvagg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hannahhoward @rvagg