Skip to content

Breakup messages w/ response codes #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

hannahhoward
Copy link
Collaborator

Goals

If a request is paused, that information should get transmitted somehow, even if the request is quickly unpaused. This changes a behavior where if you pause your request then quickly unpause the record of pausing might never be transmitted to the client. This presents problems to clients for whom the pausing may convey other semantic information.

Implementation

  • For any operation on Peer Response Sender, breakup to the next ResponseBuilder if there is already a explicit response code for the given request ID in the message.
  • Add method to ResponseBuilder to query this information

if a message has an explicit response code for a request ID, send the next message before sending
more blocks or other codes in that message
@mvdan mvdan deleted the feat/responsec-codes-unique branch December 15, 2021 14:16
marten-seemann pushed a commit that referenced this pull request Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant