This repository was archived by the owner on Feb 7, 2024. It is now read-only.
pubsub: undo workaround of skipping first message #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Thanks! |
ghost
approved these changes
Nov 20, 2017
|
@keks exactly as I thought during the IPFS All Hands -- ipfs/team-mgmt#526 --, js-ipfs-api catches the deserialization error and ignores that first message https://github.com/ipfs/js-ipfs-api/blob/master/src/utils/pubsub-message-stream.js#L20-L26 All good! |
|
ipfs/kubo#4402 is in, tests pass, let's merge! |
ghost
deleted the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes pubsub after ipfs/kubo#4402 is in.
Before the commands rewrite we made go-ipfs send out the http response immediately by first sending an empty pubsub message. It was only there to force flushing the http connection. This message was discarded on the go-ipfs-api side.
Now go-ipfs uses the new cmds library. We can now properly flush and got rid of this hack. Therefore we mustn't drop the first message anymore.
@diasdavid I presume you'll have to make this change to js-ipfs-api as well?