Skip to content
This repository was archived by the owner on Jun 27, 2023. It is now read-only.

Update builder.go #133

Merged
merged 2 commits into from
Feb 10, 2023
Merged

Update builder.go #133

merged 2 commits into from
Feb 10, 2023

Conversation

cpucorecore
Copy link
Contributor

this will lose block when newRoot.AddChild returns err. in ipfs-cluster single dag service add(context.TODO(), node) maybe failed when not enough peers to allocate for this block node

@welcome
Copy link

welcome bot commented Dec 14, 2022

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@lidel lidel requested a review from Jorropo February 6, 2023 14:48
@lidel
Copy link
Member

lidel commented Feb 6, 2023

@Jorropo you may be most familiar to review this.

cpucorecore and others added 2 commits February 10, 2023 14:22
this will lose block when newRoot.AddChild returns err.
in ipfs-cluster single dag service add(context.TODO(), node) maybe failed when not enough peers to allocate for this block node
Copy link
Contributor

@Jorropo Jorropo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Ty 🎉

@Jorropo Jorropo merged commit b7f6de0 into ipfs:master Feb 10, 2023
@Jorropo
Copy link
Contributor

Jorropo commented Feb 10, 2023

@cpucorecore do you need a release of this ?

@cpucorecore
Copy link
Contributor Author

@cpucorecore do you need a release of this ?

thank u for your quick and nice reply.
yes, please release it if it's convenient

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants