Skip to content

refactor: remove mocha/chai, fix e2e on windows #2007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 4, 2022
Merged

refactor: remove mocha/chai, fix e2e on windows #2007

merged 6 commits into from
Mar 4, 2022

Conversation

lidel
Copy link
Member

@lidel lidel commented Mar 3, 2022 •
edited
Loading

  • dependency checks
  • remove mocha
  • remove chai*
  • fix CI on windows

lidel added 3 commits March 3, 2022 21:36
@lidel
fix(ci): fetch webui over ipfs
41f9841 
this will try using IPFS, and fallback to HTTP only as the last resort
@lidel
fix(ci): same hash on windows
c5f54a6 
this solves the problem described in:
actions/runner#498
actions/checkout#135
@lidel
chore: playwright version bump
354b34a
@lidel lidel force-pushed the fix/webui-ipfs-fetch branch 4 times, most recently from 4dd1b28 to d619474 Compare March 4, 2022 00:51
@lidel lidel force-pushed the fix/webui-ipfs-fetch branch 2 times, most recently from 3d71cad to 881a5f5 Compare March 4, 2022 01:47
@lidel
refactor: remove mocha and chai
9fa27d2 
reusing @playwright/test
@lidel lidel force-pushed the fix/webui-ipfs-fetch branch 3 times, most recently from 1aa33e7 to 29cd6a8 Compare March 4, 2022 12:52
@lidel lidel changed the title fix(ci): fetch webui over ipfs refactor: remove mocha/chai, fix e2e on windows Mar 4, 2022
@lidel lidel force-pushed the fix/webui-ipfs-fetch branch from 29cd6a8 to 81d7cf8 Compare March 4, 2022 13:23
@lidel lidel marked this pull request as ready for review March 4, 2022 13:28
@lidel lidel force-pushed the fix/webui-ipfs-fetch branch from 81d7cf8 to d1603ef Compare March 4, 2022 13:34
@lidel lidel merged commit a9c7fe0 into main Mar 4, 2022
@lidel lidel deleted the fix/webui-ipfs-fetch branch March 4, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lidel