fix: do not send consent removal event #1768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm updating the test to verify this change |
olizilla
force-pushed
the
dont-send-consent-removal-event
branch
from
045322b to
318b563
Compare
|
I need to figure out if this plays nicely with ipfs-desktop |
olizilla
force-pushed
the
dont-send-consent-removal-event
branch
from
318b563 to
8fdd80a
Compare
- Saying no to analytics explicitly calls `Countly.opt_out`. Without this removing all consents triggers a "consent removed" event to be tracked which is not what we want. - Removing all individual consents explicitly calls `Countly.opt_out` - Granting consent for 1 or more analytic types opts back in to analytics by calling `Countly.opt_in`. - Saying yes to analytics explicitly calls `Countly.opt_in`, for completeness. ref: #1041 (comment) License: MIT Signed-off-by: Oli Evans <[email protected]>
olizilla
force-pushed
the
dont-send-consent-removal-event
branch
from
8fdd80a to
fca81e6
Compare
olizilla
changed the title
lidel
approved these changes
Apr 26, 2021
There was a problem hiding this comment.
LGTM, confirmed the countly is no longer pinged. Thank you @olizilla ❤️
If you want to test against Desktop do it from PR branch of ipfs/ipfs-desktop#1807 to ensure the latest electron is used.
Anyway, merging, if there is additional work for Desktop, can be a new PR.
This was referenced Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Countly.opt_out. Without this removing all consents triggers a "consent removed" event to be tracked which is not what we want.Countly.opt_outCountly.opt_in.Countly.opt_in, for completeness.ref: #1041 (comment)
License: MIT
Signed-off-by: Oli Evans [email protected]