feat: support aborting exports #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a `signal` option to the exporter that will be passed to `ipld.get`, allowing it to be notified that the user is no longer interested in exporting the file/directory/etc. Current behaviour is that if the node is offline and a block is not in the repo is will throw, if it's online the CID will be added to the bitswap want list via the block service. Follow up PRs to ipld, block service and bitswap will impelement the removal logic.
hugomrdias
approved these changes
Apr 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
signaloption to the exporter that will be passed toipld.get, allowing it to be notified that the user is no longer interested in exporting the file/directory/etc.Current behaviour is that if the node is offline and a block is not in the repo is will throw, if it's online the CID will be added to the bitswap want list via the block service.
Follow up PRs to ipld, block service and bitswap will implement the removal logic.