This repository was archived by the owner on Feb 12, 2024. It is now read-only.
chore: do not add newlines to object data #1352
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency with go-ipfs we should not add newlines to the output of
ipfs object data
.go:
js without this PR (with experimental mfs support) - note the extra
0a
at the end:js with this PR:
You may notice that the CIDs are different between go and js although the content is identical - this is because they structure the DAG differently for small files - js uses a single node if the data will fit in one node, go always creates one child that holds the data but this can be addressed in a separate PR.