This repository was archived by the owner on Feb 12, 2024. It is now read-only.
feat: enable DHT by Routing.Type config key #3153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Allows overriding `libp2p` config with a `libp2p` key in the config file 2. Enables testing the DHT for node and electron main 3. Updates Core API to be compliant with the docs
jacobheun
approved these changes
Jul 10, 2020
There was a problem hiding this comment.
One minor doc clarification otherwise this looks good.
We should ensure this releases with [email protected] and the upcoming dht patch (should be 0.19.9)
vasco-santos
approved these changes
Jul 10, 2020
Co-authored-by: Jacob Heun <[email protected]>
|
I've updated the minimum required libp2p & kad-dht and will merge when CI is green. |
achingbrain
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'none'default, DHT disabled'dht'DHT start-as-client-auto-upgrade-to-server (not implemented injs-libp2p-kad-dhtyet)'dhtserver'DHT server mode'dhtclient'DHT client mode