feat(init): Add the possibility to pass options to init() #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dignifiedquire can I get a CR for this? |
|
@haadcode can I get a test for that :) |
haadcode
force-pushed
the
feat/optstoinit
branch
from
6fd1d02 to
9f1a24c
Compare
dignifiedquire
suggested changes
Dec 20, 2016
| @@ -345,8 +371,9 @@ describe('ipfs-api version', function () { | |||
| }) | |||
| }) | |||
|
|
|||
| // NOTE: if you change ../src/, the hash will need to be changed | |||
There was a problem hiding this comment.
this should be if you change fixtures
haadcode
force-pushed
the
feat/optstoinit
branch
from
7bc885e to
2bb5dd7
Compare
dignifiedquire
approved these changes
Dec 20, 2016
|
Thank you @haadcode |
|
🙌🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will change the local() api so that options object can be passed to it.
PRing this again (original #109).