Skip to content

assets: add [email protected] GPG key #2997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 2, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ Please put all issues regarding the Go IPFS _implementation_ in [this repo](http

The IPFS protocol and its implementations are still in heavy development. This means that there may be problems in our protocols, or there may be mistakes in our implementations. And -- though IPFS is not production-ready yet -- many people are already running nodes in their machines. So we take security vulnerabilities very seriously. If you discover a security issue, please bring it to our attention right away!

If you find a vulnerability that may affect live deployments -- for example, by exposing a remote execution exploit -- please send your report privately to [email protected]. Please DO NOT file a public issue.
If you find a vulnerability that may affect live deployments -- for example, by exposing a remote execution exploit -- please send your report privately to [email protected]. Please DO NOT file a public issue. The GPG key for [email protected] is [4B9665FB 92636D17 7C7A86D3 50AAE8A9 59B13AF3](https://pgp.mit.edu/pks/lookup?op=get&search=0x50AAE8A959B13AF3).

If the issue is a protocol weakness that cannot be immediately exploited or something not yet deployed, just discuss it openly.

Expand Down
12 changes: 9 additions & 3 deletions assets/assets.go
Original file line number Diff line number Diff line change
@@ -1,17 +1,21 @@
//go:generate go-bindata -pkg=assets init-doc ../vendor/dir-index-html-v1.0.0
//go:generate go-bindata -pkg=assets -prefix=$GOPATH/src/gx/ipfs/QmQfeKxQtBN721pekQh6Jq24adFUjnU65YdY3GNczfuG2T init-doc $GOPATH/src/gx/ipfs/QmQfeKxQtBN721pekQh6Jq24adFUjnU65YdY3GNczfuG2T/dir-index-html
//go:generate gofmt -w bindata.go

package assets

import (
"bytes"
"fmt"
"os"
"path/filepath"

"github.com/ipfs/go-ipfs/core"
"github.com/ipfs/go-ipfs/core/coreunix"
uio "github.com/ipfs/go-ipfs/unixfs/io"
cid "gx/ipfs/QmXfiyr2RWEXpVDdaYnD2HNiBk6UBddsvEP4RPfXb6nGqY/go-cid"

// this import keeps gx from thinking the dep isn't used
_ "gx/ipfs/QmQfeKxQtBN721pekQh6Jq24adFUjnU65YdY3GNczfuG2T/dir-index-html"
)

// initDocPaths lists the paths for the docs we want to seed during --init
Expand All @@ -22,16 +26,18 @@ var initDocPaths = []string{
filepath.Join("init-doc", "contact"),
filepath.Join("init-doc", "security-notes"),
filepath.Join("init-doc", "quick-start"),
filepath.Join("init-doc", "ping"),
}

// SeedInitDocs adds the list of embedded init documentation to the passed node, pins it and returns the root key
func SeedInitDocs(nd *core.IpfsNode) (*cid.Cid, error) {
return addAssetList(nd, initDocPaths)
}

var initDirPath = filepath.Join(os.Getenv("GOPATH"), "gx", "ipfs", "QmQfeKxQtBN721pekQh6Jq24adFUjnU65YdY3GNczfuG2T", "dir-index-html")
var initDirIndex = []string{
filepath.Join("..", "vendor", "dir-index-html-v1.0.0", "knownIcons.txt"),
filepath.Join("..", "vendor", "dir-index-html-v1.0.0", "dir-index.html"),
filepath.Join(initDirPath, "knownIcons.txt"),
filepath.Join(initDirPath, "dir-index.html"),
}

func SeedInitDirIndex(nd *core.IpfsNode) (*cid.Cid, error) {
Expand Down
211 changes: 138 additions & 73 deletions assets/bindata.go

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions assets/init-doc/ping
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
ipfs
4 changes: 4 additions & 0 deletions assets/init-doc/security-notes
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ Please note the following:
user provided data. But please point any problems out to us in a
github issue, or email [email protected] privately.

- [email protected] GPG key:
- 4B9665FB 92636D17 7C7A86D3 50AAE8A9 59B13AF3
- https://pgp.mit.edu/pks/lookup?op=get&search=0x50AAE8A959B13AF3

- ipfs uses encryption for all communication, but it's NOT PROVEN SECURE
YET! It may be totally broken. For now, the code is included to make
sure we benchmark our operations with encryption in mind. In the future,
Expand Down
5 changes: 2 additions & 3 deletions core/corehttp/gateway_indexPage.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@ type directoryItem struct {
var listingTemplate *template.Template

func init() {
assetPath := "../vendor/dir-index-html-v1.0.0/"
knownIconsBytes, err := assets.Asset(assetPath + "knownIcons.txt")
knownIconsBytes, err := assets.Asset("dir-index-html/knownIcons.txt")
if err != nil {
panic(err)
}
Expand All @@ -53,7 +52,7 @@ func init() {
}

// Directory listing template
dirIndexBytes, err := assets.Asset(assetPath + "dir-index.html")
dirIndexBytes, err := assets.Asset("dir-index-html/dir-index.html")
if err != nil {
panic(err)
}
Expand Down
7 changes: 7 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,13 @@
"hash": "QmRcAVqrbY5wryx7hfNLtiUZbCcstzaJL7YJFBboitcqWF",
"name": "go-ipld-cbor",
"version": "0.3.0"
},
{
"author": "lgierth",
"hash": "QmQfeKxQtBN721pekQh6Jq24adFUjnU65YdY3GNczfuG2T",
"name": "dir-index-html",
"version": "1.0.3",
"comment": "This one needs code updates in assets/assets.go too."
}
],
"gxVersion": "0.4.0",
Expand Down
4 changes: 1 addition & 3 deletions test/sharness/lib/test-lib-hashes.sh
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
# this file defines several useful hashes used across the test codebase.
# thus they can be defined + changed in one place

HASH_WELCOME_DOCS="QmYwAPJzv5CZsnA625s3Xf2nemtYgPpHdWEz79ojWnPbdG"
HASH_GATEWAY_ASSETS="QmXB7PLRWH6bCiwrGh2MrBBjNkLv3mY3JdYXCikYZSwLED"
HASH_HELP_PAGE="QmY5heUM5qgRubMDD1og9fhCPA6QdkMp3QCwd4s7gJsyE7"
HASH_WELCOME_DOCS="QmVLDAhCY3X9P2uRudKAryuQFPM5zqA3Yij1dY8FpGbL7T"
HASH_EMPTY_DIR="QmUNLLsPACCz1vLxQVkXqqLX5R1X345qqfHbsf67hvA3Nn"