Skip to content

[RFR] Split settings config #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

mattboon
Copy link
Contributor

@mattboon mattboon commented Nov 7, 2016

@artibella adds setting and translation helpers.

import { setting } from 'settings';
import { translation } from 'settings';

setting('dateFormat');
translation('homePage.modal.button');

Huge job to retrofit them into all the places we use settings.x though.

@artibella artibella temporarily deployed to iris-frontend-dev-pr-206 November 7, 2016 17:08 Inactive
@mattboon
Copy link
Contributor Author

mattboon commented Nov 7, 2016

Or do you think it should be split even more?

import { translation } from 'translations';

@artibella artibella temporarily deployed to iris-frontend-dev-pr-206 November 7, 2016 17:24 Inactive
@artibella artibella temporarily deployed to iris-frontend-dev-pr-206 November 8, 2016 07:25 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants