Skip to content

Fix GitHub Actions build warnings, Marker style should be * #1925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions CppCoreGuidelines.md
Original file line number Diff line number Diff line change
Expand Up @@ -16129,17 +16129,17 @@ The standard library assumes that destructors, deallocation functions (e.g., `op

##### Note

- Deallocation functions, including `operator delete`, must be `noexcept`.
- `swap` functions must be `noexcept`.
- Most destructors are implicitly `noexcept` by default.
- Also, [make move operations `noexcept`](#Rc-move-noexcept).
- If writing a type intended to be used as an exception type, ensure its copy constructor is not `noexcept`. In general we cannot mechanically enforce this, because we do not know whether a type is intended to be used as an exception type.
- Try not to `throw` a type whose copy constructor is not `noexcept`. In general we cannot mechanically enforce this, because even `throw std::string(...)` could throw but does not in practice.
* Deallocation functions, including `operator delete`, must be `noexcept`.
* `swap` functions must be `noexcept`.
* Most destructors are implicitly `noexcept` by default.
* Also, [make move operations `noexcept`](#Rc-move-noexcept).
* If writing a type intended to be used as an exception type, ensure its copy constructor is not `noexcept`. In general we cannot mechanically enforce this, because we do not know whether a type is intended to be used as an exception type.
* Try not to `throw` a type whose copy constructor is not `noexcept`. In general we cannot mechanically enforce this, because even `throw std::string(...)` could throw but does not in practice.

##### Enforcement

- Catch destructors, deallocation operations, and `swap`s that `throw`.
- Catch such operations that are not `noexcept`.
* Catch destructors, deallocation operations, and `swap`s that `throw`.
* Catch such operations that are not `noexcept`.

**See also**: [discussion](#Sd-never-fail)

Expand Down