Skip to content

feat(DestinationRules): Adding aggression and min_weight_percent to DestinationRules API #3216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
237 changes: 237 additions & 0 deletions kubernetes/customresourcedefinitions.gen.yaml

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions networking/v1/destination_rule_alias.gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

846 changes: 479 additions & 367 deletions networking/v1alpha3/destination_rule.pb.go

Large diffs are not rendered by default.

58 changes: 56 additions & 2 deletions networking/v1alpha3/destination_rule.pb.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 12 additions & 0 deletions networking/v1alpha3/destination_rule.proto
Original file line number Diff line number Diff line change
Expand Up @@ -377,6 +377,7 @@ message Subset {
// ```
//
message LoadBalancerSettings {
// +kubebuilder:validation:XValidation:message="only one of warmupDurationSecs or warmup can be set",rule="(has(self.warmupDurationSecs)?1:0)+(has(self.warmup)?1:0)<=1"
// Standard load balancing algorithms that require no tuning.
enum SimpleLB {
// No load balancing algorithm has been specified by the user. Istio
Expand Down Expand Up @@ -514,9 +515,20 @@ message LoadBalancerSettings {
// endpoints are relatively new like new deployment, this is not very effective as all endpoints end up getting same
// amount of requests.
// Currently this is only supported for ROUND_ROBIN and LEAST_REQUEST load balancers.
// Deprecated: use `warmup` instead.
google.protobuf.Duration warmup_duration_secs = 4;

WarmupConfiguration warmup = 5;
}

message WarmupConfiguration {
google.protobuf.Duration duration = 1;
// +kubebuilder:validation:Maximum=100
// +kubebuilder:validation:Minimum=0
google.protobuf.DoubleValue minimum_percent = 2;
// +kubebuilder:validation:Minimum=0
google.protobuf.DoubleValue aggression = 3;
}
// Connection pool settings for an upstream host. The settings apply to
// each individual host in the upstream service. See Envoy's [circuit
// breaker](https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/upstream/circuit_breaking)
Expand Down
21 changes: 21 additions & 0 deletions networking/v1alpha3/destination_rule_deepcopy.gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 11 additions & 0 deletions networking/v1alpha3/destination_rule_json.gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions networking/v1beta1/destination_rule_alias.gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
apiVersion: release-notes/v2

kind: feature
area: traffic-management
issue:
- 3215

releaseNotes:
- |
**Added** aggression and minimum_percent parameters

docs:
- https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/upstream/load_balancing/slow_start