Skip to content
This repository was archived by the owner on Apr 23, 2025. It is now read-only.

home: add bitbucket #362

Merged
merged 14 commits into from
Nov 9, 2022
Merged

home: add bitbucket #362

merged 14 commits into from
Nov 9, 2022

Conversation

DavidGOrtega
Copy link
Contributor

@DavidGOrtega DavidGOrtega commented Oct 30, 2022

Right now is missing:


In review app: https://cml-dev-forge-bitbucket-x1ubcz.herokuapp.com/#use-cases

@DavidGOrtega DavidGOrtega marked this pull request as draft October 30, 2022 08:29
@shcheklein shcheklein temporarily deployed to cml-dev-forge-bitbucket-x1ubcz October 30, 2022 08:29 Inactive
@github-actions

This comment was marked as outdated.

@shcheklein shcheklein temporarily deployed to cml-dev-forge-bitbucket-x1ubcz October 30, 2022 08:38 Inactive
@shcheklein shcheklein temporarily deployed to cml-dev-forge-bitbucket-x1ubcz October 30, 2022 08:56 Inactive
@shcheklein shcheklein temporarily deployed to cml-dev-forge-bitbucket-x1ubcz October 30, 2022 10:01 Inactive
@DavidGOrtega DavidGOrtega self-assigned this Oct 30, 2022
@DavidGOrtega DavidGOrtega added the p1-important High priority label Oct 30, 2022
@DavidGOrtega

This comment was marked as outdated.

@shcheklein shcheklein temporarily deployed to cml-dev-forge-bitbucket-x1ubcz October 30, 2022 11:50 Inactive
@0x2b3bfa0
Copy link
Member

Right now is missing: [...] the repos.

@0x2b3bfa0
Copy link
Member

update https://github.com/iterative/cml-examples-dev accordingly to the yaml displayed here

Done for everything but the GPU example, which doesn't exist because it's not supported.

* Update example repositories

* Fix some broken links

* Fix more links
@shcheklein shcheklein temporarily deployed to cml-dev-forge-bitbucket-x1ubcz November 1, 2022 21:40 Inactive
@shcheklein shcheklein temporarily deployed to cml-dev-forge-bitbucket-x1ubcz November 1, 2022 21:42 Inactive
@github-actions
Copy link

github-actions bot commented Nov 1, 2022

d177ffd

Link Check Report

There were no links to check!

@DavidGOrtega
Copy link
Contributor Author

All 50 links passed!

Checked then ✅

@shcheklein shcheklein temporarily deployed to cml-dev-forge-bitbucket-x1ubcz November 2, 2022 11:05 Inactive
@jorgeorpinel jorgeorpinel added the documentation Markdown files label Nov 2, 2022
@jorgeorpinel jorgeorpinel added the A: website Area: website label Nov 2, 2022
@shcheklein shcheklein had a problem deploying to cml-dev-forge-bitbucket-x1ubcz November 3, 2022 13:08 Failure
@DavidGOrtega DavidGOrtega marked this pull request as ready for review November 3, 2022 13:13
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As stated before, I believe we shouldn't provide any Bitbucket GPU example code unless it works.

Approving with the expectation of seeing #362 (comment) addressed in a follow-up pull request.

@DavidGOrtega
Copy link
Contributor Author

opens #367

@casperdcl casperdcl mentioned this pull request Nov 4, 2022
13 tasks
Copy link
Contributor

@casperdcl casperdcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are absolutely definitely not moving from iterative([.-]ai)? to a new iterative-test org on all git hosts. https://github.com/iterative/cml-examples-dev is using the *-test orgs just for hacky dev purposes, they are not and will never be official.

And when we do migrate to better demo repo names, it'll be in a different PR as part of https://github.com/iterative/cml-examples-dev/issues/9

)}
bitbucket={(
<Collapser>
<Code filename="bitbucket-pipelines.yml" repo="https://bitbucket.org/iterative-test/cml-example-cloud">
Copy link
Contributor

@casperdcl casperdcl Nov 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Code filename="bitbucket-pipelines.yml" repo="https://bitbucket.org/iterative-test/cml-example-cloud">
<Code filename="bitbucket-pipelines.yml" repo="https://bitbucket.org/iterative-ai/cml-example-cloud-gpu">

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shcheklein shcheklein temporarily deployed to cml-dev-forge-bitbucket-x1ubcz November 4, 2022 23:58 Inactive
@casperdcl casperdcl changed the title Forge bitbucket home: add bitbucket Nov 5, 2022
Copy link
Contributor

@rogermparent rogermparent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks quite solid from a code standpoint. Nice work! I'd be totally fine merging this code (once the content is ready, of course!) and we can handle duplication later- theme-ui's days are numbered once iterative/gatsby-theme-iterative#33 is in and makes it way here, so that duplication issue will be solved then.

@0x2b3bfa0 0x2b3bfa0 requested a review from a team as a code owner November 8, 2022 21:32
@shcheklein shcheklein temporarily deployed to cml-dev-forge-bitbucket-x1ubcz November 8, 2022 21:33 Inactive
@shcheklein shcheklein temporarily deployed to cml-dev-forge-bitbucket-x1ubcz November 8, 2022 22:31 Inactive
Copy link
Contributor

@casperdcl casperdcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for now to unblock :)

@0x2b3bfa0
Copy link
Member

Merging because I feel bored 🥱

@0x2b3bfa0 0x2b3bfa0 merged commit d177ffd into master Nov 9, 2022
@0x2b3bfa0 0x2b3bfa0 deleted the forge-bitbucket branch November 9, 2022 10:07
@0x2b3bfa0
Copy link
Member

Approving for now

...and forever [hold your peace] 😉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A: website Area: website documentation Markdown files p1-important High priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add Bitbucket to home page
8 participants