-
Notifications
You must be signed in to change notification settings - Fork 23
Document GitLab with private container registries #414
Conversation
LGTM but can't confirm the correctness (i.e. approve). |
Co-authored-by: Jorge Orpinel <[email protected]>
Link Check ReportAll 9 links passed! |
@@ -448,7 +448,101 @@ The same credentials can also be used for | |||
|
|||
</admon> | |||
|
|||
### On-premise (Local) Runners | |||
## GitLab CI/CD and container images from private registries |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is GL specific? what about GH?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The closest approximation I can think of is this (not working) example:
on: push
jobs:
authentication:
runs-on: ubuntu-latest
outputs:
username: ${{ steps.authenticate.outputs.username }}
password: ${{ steps.authenticate.outputs.password }}
steps:
- id: authenticate
run: |
echo "username=AWS" >> $GITHUB_OUTPUT
echo "password=$(aws ecr get-login-password --region us-east-1)" >> $GITHUB_OUTPUT
env:
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
example:
needs: authentication
runs-on: ubuntu-latest
container:
image: ACCOUNT.dkr.ecr.REGION.amazonaws.com/REPOSITORY:TAG
credentials:
username: ${{ needs.authentication.outputs.username }}
password: ${{ needs.authentication.outputs.password }}
steps:
- run: true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kewl. I think this perhaps deserves a new page?
or perhaps https://cml.dev/doc/ref/runner#examples?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is about self-hosted runners, on GitLab, with private container registries. Definition of niche.
🔔 @casperdcl: meow! 🐱 |
@0x2b3bfa0 can we merge this? |
Yes! @shcheklein, can you please approve it? |
Closes #387, opens #413