Skip to content

feat: ignore files not in remote when push is false #10749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Northo
Copy link

@Northo Northo commented May 22, 2025

Fixes #10317

Enables opt-in to remove push: false stage outputs from not_in_remote data status results.

Notable changes:

  • Add outs_no_push to dvc.stage.utils.fill_stage_outputs keys, to facilitate making outputs with push: false.
  • In status, when flag enabled, filter through files reported as not_in_remote, and remove them if not can_push.
  • Add corresponding flag --respect-no-push flag to CLI

Open to suggestions on how to make the flag names more intuitive!

Corresponding PR for the docs: iterative/dvc.org#5373

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

Copy link

codecov bot commented May 22, 2025

Codecov Report

Attention: Patch coverage is 93.10345% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.10%. Comparing base (2431ec6) to head (b5a6a58).
Report is 51 commits behind head on main.

Files with missing lines Patch % Lines
dvc/repo/data.py 86.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10749      +/-   ##
==========================================
+ Coverage   90.68%   91.10%   +0.41%     
==========================================
  Files         504      504              
  Lines       39795    39997     +202     
  Branches     3141     3160      +19     
==========================================
+ Hits        36087    36438     +351     
+ Misses       3042     2934     -108     
+ Partials      666      625      -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Northo Northo force-pushed the fix/10317/ignore-not-in-remote-push-false branch 3 times, most recently from a3fe1e0 to 4537674 Compare May 22, 2025 12:33
@Northo Northo force-pushed the fix/10317/ignore-not-in-remote-push-false branch from 4537674 to b5a6a58 Compare May 22, 2025 12:58
@Northo Northo changed the title Fix/10317/ignore not in remote push false feat: ignore files not in remote when push is false May 22, 2025
@Northo Northo marked this pull request as ready for review May 22, 2025 13:24
@skshetry skshetry added this to DVC May 25, 2025
@skshetry skshetry moved this to Review In Progress in DVC May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Review In Progress
Development

Successfully merging this pull request may close these issues.

data status returns files as "Not in remote" even though they are marked as push: false in pipeline
1 participant