Skip to content

ignore: remove dulwich in favour of pathspec #2159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2019

Conversation

pared
Copy link
Contributor

@pared pared commented Jun 19, 2019

  • Have you followed the guidelines in our
    Contributing document?

  • Does your PR affect documented changes or does it add new functionality
    that should be documented? If yes, have you created a PR for
    dvc.org documenting it or at
    least opened an issue for it? If so, please add a link to it.


related to #1876

Edit:
When (if) this change is approved, we should create issue to optimize pathspec usage. Now, during dvc_walk we check files one by one, while pathspec allows to check set/list of paths against spec.

Edit 2:
But first it might be better to do some performance testing if its worth our time

Copy link
Contributor

@Suor Suor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like straightforward simplification 👍

The whole ignore thing looks too complicated though, but this PR is certainly not about that.

@pared
Copy link
Contributor Author

pared commented Jun 20, 2019

@Suor About ignore complication: lets continue this discussion in #2161 , I think it will be strictly related to this task.

@Suor
Copy link
Contributor

Suor commented Jun 20, 2019

@pared can't see so how #2161 is related to the whole complexity of the ignore implementation. Looks like that does particular feature/bug fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants