Skip to content

Wrong telemetry file path #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
0x2b3bfa0 opened this issue Jul 8, 2022 · 0 comments · Fixed by #32
Closed

Wrong telemetry file path #33

0x2b3bfa0 opened this issue Jul 8, 2022 · 0 comments · Fixed by #32

Comments

@0x2b3bfa0
Copy link
Member

@DavidGOrtega [re]discovered that the appdirs argument on this project don't follow the specification.

https://github.com/iterative/iterative-telemetry/blob/e552363eafce5a01bebf33ea8ac69d59d2b5b41f/src/iterative_telemetry/__init__.py#L199

The second argument to user_data_dir is only being honored on Windows, and doesn't produce the desired behavior on other platforms.

"appauthor" (only used on Windows) is the name of the appauthor or distributing body for this application. Typically it is the owning company name. This falls back to appname. You may pass False to disable it.

The correct form would be #32 (comment)

Note
I wrote this issue before recalling that it's already being [re]solved with #32.

@0x2b3bfa0 0x2b3bfa0 linked a pull request Jul 8, 2022 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant