Skip to content

fix config path & format #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jul 20, 2022
Merged

fix config path & format #32

merged 15 commits into from
Jul 20, 2022

Conversation

casperdcl
Copy link
Contributor

@casperdcl casperdcl commented Jul 5, 2022 •
edited
Loading

vis:

@casperdcl casperdcl added the bug Something isn't working label Jul 5, 2022
@casperdcl casperdcl requested a review from mike0sv July 5, 2022 11:01
@casperdcl casperdcl self-assigned this Jul 5, 2022
@casperdcl casperdcl requested a review from 0x2b3bfa0 July 5, 2022 11:02
0x2b3bfa0
0x2b3bfa0 approved these changes Jul 5, 2022 •
edited
Loading
View reviewed changes
@casperdcl casperdcl mentioned this pull request Jul 5, 2022
Closed
@casperdcl casperdcl changed the title fix config path fix config path & format Jul 5, 2022
omesser
omesser suggested changes Jul 5, 2022
View reviewed changes
Copy link

@omesser omesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor stuff (if we're going with that, looks like #31 will be similar, duh

mike0sv
mike0sv reviewed Jul 5, 2022
View reviewed changes
mike0sv
mike0sv reviewed Jul 5, 2022
View reviewed changes
efiop
efiop reviewed Jul 5, 2022
View reviewed changes
efiop
efiop suggested changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather go with #31

efiop
efiop reviewed Jul 5, 2022
View reviewed changes
efiop
efiop reviewed Jul 5, 2022
View reviewed changes
efiop
efiop reviewed Jul 5, 2022
View reviewed changes
efiop
efiop reviewed Jul 5, 2022
View reviewed changes
casperdcl added 4 commits July 6, 2022 16:30
@casperdcl
Revert "expose write_legacy"
79529a7 
This reverts commit af1366f.
@casperdcl
overhaul logic
a86ca2d 
- drop writing to legacy location, vis.:
#32 (comment)
- lint & update names
@casperdcl
minor docstring updates
c1cfc98
@casperdcl
fd => fobj
821aa56
@casperdcl casperdcl requested review from omesser and efiop and removed request for 0x2b3bfa0 July 6, 2022 16:21
efiop
efiop reviewed Jul 6, 2022
View reviewed changes
efiop
efiop reviewed Jul 6, 2022
View reviewed changes
efiop
efiop reviewed Jul 6, 2022
View reviewed changes
efiop
efiop reviewed Jul 6, 2022
View reviewed changes
efiop
efiop reviewed Jul 6, 2022
View reviewed changes
mike0sv
mike0sv reviewed Jul 6, 2022
View reviewed changes
mike0sv
mike0sv reviewed Jul 6, 2022
View reviewed changes
@0x2b3bfa0 0x2b3bfa0 mentioned this pull request Jul 8, 2022
Closed
@0x2b3bfa0 0x2b3bfa0 linked an issue Jul 8, 2022 that may be closed by this pull request
Wrong telemetry file path #33
Closed
@casperdcl casperdcl requested a review from efiop July 18, 2022 11:32
efiop
efiop reviewed Jul 18, 2022
View reviewed changes
@casperdcl casperdcl requested a review from efiop July 20, 2022 09:10
@efiop efiop merged commit 98afb40 into main Jul 20, 2022
@casperdcl casperdcl deleted the fix-config-path branch July 21, 2022 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mike0sv mike0sv mike0sv left review comments

@0x2b3bfa0 0x2b3bfa0 0x2b3bfa0 approved these changes

@efiop efiop efiop approved these changes

@omesser omesser Awaiting requested review from omesser

Assignees

@casperdcl casperdcl

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong telemetry file path Respect old DVC user-id
5 participants
@casperdcl @efiop @mike0sv @0x2b3bfa0 @omesser