Skip to content

Avoid rclone error message on task logs #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2022
Merged

Avoid rclone error message on task logs #466

merged 1 commit into from
Mar 31, 2022

Conversation

0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 commented Mar 30, 2022 •
edited
Loading

Before, the makeConfigPath function returned a default path, producing an unhelpful warning message. Setting the RCLONE_CONFIG environment variable to to an empty string causes that function to return a bit earlier, and causing configPath to be an empty string, replacing the warning with a silent debug message.

@0x2b3bfa0 0x2b3bfa0 linked an issue Mar 30, 2022 that may be closed by this pull request
task rclone Config file not found #373
Closed
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic March 30, 2022 20:13 Inactive
@0x2b3bfa0 0x2b3bfa0 requested a review from a team March 30, 2022 20:13
@0x2b3bfa0 0x2b3bfa0 self-assigned this Mar 30, 2022
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic March 30, 2022 20:13 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic March 30, 2022 20:13 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic March 30, 2022 20:13 Inactive
@0x2b3bfa0 0x2b3bfa0 added enhancement New feature or request ui/ux User interface/experience labels Mar 30, 2022
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic March 30, 2022 20:53 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic March 30, 2022 20:53 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic March 30, 2022 20:53 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic March 30, 2022 20:53 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic March 30, 2022 21:57 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic March 30, 2022 21:57 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic March 30, 2022 21:57 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic March 30, 2022 21:57 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic March 30, 2022 21:57 Inactive
@DavidGOrtega
Copy link
Contributor

might close ?

DavidGOrtega
DavidGOrtega approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@DavidGOrtega DavidGOrtega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 lgtm

@0x2b3bfa0
Copy link
Member Author

might close? #373

Yes, it does; see the linked issue in the Development section of the right side bar.

@0x2b3bfa0 0x2b3bfa0 merged commit 1da8537 into master Mar 31, 2022
@0x2b3bfa0 0x2b3bfa0 deleted the 373-task-rclone-config-file-not-found branch March 31, 2022 11:29
@0x2b3bfa0 0x2b3bfa0 added the resource-task iterative_task TF resource label Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidGOrtega DavidGOrtega DavidGOrtega approved these changes

Assignees

@0x2b3bfa0 0x2b3bfa0

Labels
enhancement New feature or request resource-task iterative_task TF resource ui/ux User interface/experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

task rclone Config file not found
2 participants
@0x2b3bfa0 @DavidGOrtega