Improve TF_LOG_PROVIDER logs #471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Response times are different and the cached |
0x2b3bfa0
force-pushed
the
internal-log-hacks
branch
from
060dc43 to
2e56ae5
Compare
0x2b3bfa0
requested review from
DavidGOrtega and
a team
and removed request for
DavidGOrtega
casperdcl
reviewed
Mar 31, 2022
This was referenced Apr 1, 2022
0x2b3bfa0
commented
Apr 29, 2022
Comment on lines
+75
to
+82
| if status["succeeded"] != nil && status["succeeded"].(int) >= d.Get("parallelism").(int) { | ||
| message = fmt.Sprintf("\x1b[%dmStatus: completed succesfully 🟢\x1b[0m", colors["SUCCESS"]) | ||
| } | ||
| if status["failed"] != nil && status["failed"].(int) > 0 { | ||
| message = fmt.Sprintf("\x1b[%dmStatus: completed with errors 🔴\x1b[0m", colors["ERROR"]) | ||
| } | ||
| if status["running"] != nil && status["running"].(int) >= d.Get("parallelism").(int) { | ||
| message = fmt.Sprintf("\x1b[%dmStatus: running 🟡\x1b[0m", colors["WARNING"]) |
There was a problem hiding this comment.
Computed status, for future references
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces some visual and conceptual improvements to the
TF_LOG_PROVIDER=INFOinternal logs. This approach is still fairly unideal beyond all remedy, but at least is easier on the eyes for ANSI terminal users; see #423 (review) for context.Before
After