Update to embassy-net 0.5 #48
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And use the now release embassy-net.
ivmarkov
requested changes
Nov 28, 2024
There was a problem hiding this comment.
Looks quite OK!
If you could only address the question w.r.t. to_net_addr and to_emb_addr and if indeed not necessary - just get rid of these?
Also, I will (at least for the next couple of days) merge your PR against another branch.
Would you be willing to re-target the PR against the embassy-net-05 branch that I just created for that purpose? Thanks!
| @@ -89,11 +89,11 @@ pub(crate) fn to_emb_bind_socket(socket: SocketAddr) -> IpListenEndpoint { | |||
| pub(crate) fn to_net_addr(addr: IpAddress) -> IpAddr { | |||
There was a problem hiding this comment.
Is this function even necessary anymore given that now smoltcp (and embassy-net) did switch to core::net for IP addresses?
| @@ -102,11 +102,11 @@ pub(crate) fn to_net_addr(addr: IpAddress) -> IpAddr { | |||
| pub(crate) fn to_emb_addr(addr: IpAddr) -> IpAddress { | |||
|
Done This can be closed and we look at the other PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #35