Skip to content

feat: Add clear method for a composite signal #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions index.d.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
declare function anySignal(signals: AbortSignal[]): AbortSignal;
interface ClearableSignal extends AbortSignal {
clear(): void
}

export {anySignal};
declare function anySignal(signals: Array<AbortSignal | undefined | null>): ClearableSignal;

export {anySignal, type ClearableSignal};

export default anySignal;
18 changes: 16 additions & 2 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* Takes an array of AbortSignals and returns a single signal.
* If any signals are aborted, the returned signal will be aborted.
* @param {Array<AbortSignal>} signals
* @returns {AbortSignal}
* @returns {ClearableSignal}
*/
function anySignal (signals) {
const controller = new globalThis.AbortController()
Expand All @@ -25,7 +25,21 @@ function anySignal (signals) {
signal.addEventListener('abort', onAbort)
}

return controller.signal
function clear () {
for (const signal of signals) {
if (!signal || !signal.removeEventListener) continue
signal.removeEventListener('abort', onAbort)
}
}

return new Proxy(controller.signal, {
get (target, p) {
if (p === 'clear') {
return clear
}
return target[p]
}
})
}

module.exports = anySignal
Expand Down
63 changes: 62 additions & 1 deletion test.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,35 @@ const pDefer = require('p-defer')
const anySignal = require('./')
const { AbortController } = globalThis

// AbortSignal, with an introspection on number of "abort" event listeners
function withHandlersCount (signal) {
let abortHandlers = 0
return new Proxy(signal, {
get (target, p) {
if (p === 'addEventListener') {
return function (...args) {
abortHandlers += 1
target[p].apply(target, args)
}
}
if (p === 'removeEventListener') {
return function (...args) {
abortHandlers -= 1
target[p].apply(target, args)
}
}
if (p === '_abortHandlers') {
return abortHandlers
}
return target[p]
}
})
}

test('should abort from any signal', async t => {
const controllers = [...new Array(5)].map(() => new AbortController())
const signal = anySignal(controllers.map(c => c.signal))
const signals = controllers.map(c => withHandlersCount(c.signal))
const signal = anySignal(signals)
t.is(signal.aborted, false)
const deferred = pDefer()
let abortCount = 0
Expand All @@ -14,12 +40,17 @@ test('should abort from any signal', async t => {
deferred.resolve()
})

// Handlers added
signals.every(s => t.is(s._abortHandlers, 1))

const randomController = controllers[Math.floor(Math.random() * controllers.length)]
randomController.abort()

await deferred.promise
t.is(abortCount, 1)
t.is(signal.aborted, true)
// Handlers removed
signals.every(s => t.is(s._abortHandlers, 0))
})

test('ignores non signals', async t => {
Expand Down Expand Up @@ -72,3 +103,33 @@ test('should abort if a provided signal is already aborted', t => {
const signal = anySignal(controllers.map(c => c.signal))
t.is(signal.aborted, true)
})

test('explicitly clear handlers', t => {
const controllers = [...new Array(5)].map(() => new AbortController())
const signals = controllers.map(c => withHandlersCount(c.signal))
const signal = anySignal(signals)
// No aborts
t.is(signal.aborted, false)
// Each signal got an "abort" listener
signals.every(s => t.is(s._abortHandlers, 1))
signal.clear()
// No aborts still
t.is(signal.aborted, false)
// Each signal is clear of listeners
signals.every(s => t.is(s._abortHandlers, 0))
})

test('abort after clear', t => {
const controllers = [...new Array(5)].map(() => new AbortController())
const signals = controllers.map(c => withHandlersCount(c.signal))
const signal = anySignal(signals)
t.is(signal.aborted, false)
// Clear event handlers
signal.clear()

const randomController = controllers[Math.floor(Math.random() * controllers.length)]
randomController.abort()

// No handlers means there are no events propagated to the composite `signal`
t.is(signal.aborted, false)
})