Skip to content

feat: convert to typescript #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 13, 2023

Conversation

achingbrain
Copy link
Contributor

Converts this module to typescript and uses aegir to build and run tests.

Converts this module to typescript and uses aegir to build and run
tests.
@achingbrain
Copy link
Contributor Author

achingbrain commented Apr 13, 2023

Noticed that #24 doesn't work in browsers due to how the proxy returns function fields rather than invoking them and the tests weren't being run in browsers which would have caught that so do the ts conversion and use aegir to run tests in all supported environments.

Switches to named exports only, not sure if this is a big deal or not.

@achingbrain
Copy link
Contributor Author

To get the auto-release to work, create an npm automation token and configure it as a repository secret named NPM_TOKEN

achingbrain added a commit to achingbrain/any-signal that referenced this pull request Apr 13, 2023
Similar to jacobheun#25 - less disruptive but doesn't run any tests that
would have caught the issue.
@achingbrain achingbrain mentioned this pull request Apr 13, 2023
achingbrain added a commit to achingbrain/any-signal that referenced this pull request Apr 13, 2023
Similar to jacobheun#25 - less disruptive but doesn't run any tests that
would have caught the issue.
jacobheun pushed a commit that referenced this pull request Apr 13, 2023
Similar to #25 - less disruptive but doesn't run any tests that
would have caught the issue.
Copy link
Owner

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rad, thanks for updating, I've set the token up so autorelease should be gtg. I'm fine with the changes to exports.

@jacobheun jacobheun merged commit de5fa82 into jacobheun:master Apr 13, 2023
github-actions bot pushed a commit that referenced this pull request Apr 13, 2023
## [4.1.0](v4.0.1...v4.1.0) (2023-04-13)

### Features

* convert to typescript ([#25](#25)) ([de5fa82](de5fa82))
@achingbrain achingbrain deleted the feat/convert-to-typescript branch April 13, 2023 16:08
@achingbrain
Copy link
Contributor Author

Ha, this went out as 4.1.0, oops. Needed a feat!: or BREAKING CHANGES: ... in the commit message to bump the major.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants