Skip to content

Cannot use 'postmessage' as the callback url #51

Open
@mattmccarty

Description

@mattmccarty

On the client side, I'm using gapi to grab an authorization code from google and then passing that code to passport-google-oauth via a REST service.

Google is expecting passport to get an access token, by setting the callback to 'postmessage', otherwise a "redirect_uri_mismatch" error is returned (and yes all of my settings are correct in google's console). Unfortunately, the authenticate method on lines 140-148 (of passport-oauth2/lib/strategy.js) see 'postmessage' as a relative url and change it by calling url.resolve().

My question is, can I implement this change and forward over a pull request, or is this not something you see as an issue?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions