Skip to content

Invalid JS: Splatted statement causes if block inside array element #1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
satyr opened this issue May 11, 2011 · 2 comments
Closed

Invalid JS: Splatted statement causes if block inside array element #1349

satyr opened this issue May 11, 2011 · 2 comments
Labels
fixed

Comments

@satyr
Copy link
Collaborator

satyr commented May 11, 2011 

$ coffee -bpe '[a if b...]'
var __slice = Array.prototype.slice;
__slice.call(  if (b) {
    a;
  });

$ coffee -e '[a if b...]'

.:3
  __slice.call(    if (b) {
                   ^^
SyntaxError: Unexpected token if
@jashkenas jashkenas removed this from the as soon as a patch is available milestone Jun 2, 2015
@GeoffreyBooth GeoffreyBooth changed the title splatted statement Invalid JS: Splatted statement causes if block inside array element May 5, 2017
@GeoffreyBooth GeoffreyBooth mentioned this issue May 6, 2017
Closed
@GeoffreyBooth
Copy link
Collaborator

Either a duplicate or else very closely related to #4260.

This was referenced Aug 16, 2017
Merged
Merged
GeoffreyBooth added a commit to GeoffreyBooth/coffeescript that referenced this issue Aug 23, 2017
@GeoffreyBooth
Add test based on jashkenas#1349
5d08948
zdenko pushed a commit to GeoffreyBooth/coffeescript that referenced this issue Aug 23, 2017
Add test based on jashkenas#1349
16f782b
GeoffreyBooth pushed a commit that referenced this issue Aug 27, 2017
@zdenko @GeoffreyBooth
[CS2] Fix #4260 and #1349: Splat error with soak properties or expres…
5713b7e 
…sions (#4644)

* fix splat error with soak properties or expressions

* Add test based on #4260

* Add test based on #1349

* tests for the leading splat variant

* test for spaced prefix ...

* fixed 'if' statement in parens

* fixed replacing 'void 0' with '[]'

* remove 'void 0' replacement; add Splat::compileNode

* Use LEVEL_OP; follow style better
@GeoffreyBooth
Copy link
Collaborator

Fixed by #4644.

GeoffreyBooth pushed a commit that referenced this issue Aug 27, 2017
@zdenko @GeoffreyBooth
[CS1] fix #4260 and #1349: splat error with soak properties or expres…
6cea181 
…sions (#4643)

* fix splat error with soak properties or expressions

* Add test based on #4260

* Add test based on #1349

* remove 'void 0' replacement; add Splat::compileNode
@GeoffreyBooth GeoffreyBooth mentioned this issue Sep 2, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jashkenas @satyr @GeoffreyBooth