calling super in methods defined on namespaced classes

[michaelficarra]

C::m = -> super compiles correctly into

C.prototype.m = function() {
  return C.__super__.m.apply(this, arguments);
};

namespaced.C::m = -> super" compiles incorrectly into

namespaced.C.prototype.m = function() {
  return m.__super__.constructor.apply(this, arguments);
};

Proper compilation would have been

var _ref;
_ref = namespaced.C;
_ref.prototype.m = function() {
  return _ref.__super__.constructor.apply(this, arguments);
};

The error originates from the METHOD_DEF regex being used by Assign::compileNode matching only identifiers. Call::superReference is then compiling incorrectly.

[michaelficarra]

Note: the caching I recommend above will protect us from multiple execution in cases such as namespace().C()::m = -> super, but will also have the following effect:

namespace.A::m = (-> super)
namespace.B::m = namespace.A::m
(new namespace.B).m()

will invoke the m method on the superclass of whatever was the value of namespace.A at definition time. @jashkenas: acceptable?

[jashkenas]

Yes -- I think that's quite acceptable. Expected, even.

If your class call is a factory that's producing instances of new classes, you'd expect the one you used to define your prototype to also be used when you call super(), not a fresh class object.