Fix implicit calls with preceding herecomment #2933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -251,7 +251,7 @@ class exports.Rewriter | |||
| # which is probably always unintended. | |||
| # Furthermore don't allow this in literal arrays, as | |||
| # that creates grammatical ambiguities. | |||
| if @matchTags(i, IMPLICIT_FUNC, 'INDENT', null, ':') and | |||
There was a problem hiding this comment.
Doesn't work because the herecomment specialcasing ?
There was a problem hiding this comment.
Exactly that. The reported bug is caused by matchTags skipping the herecomment and then matching IMPLICIT_FUNC, ..., which results in CALL_START being inserted after the herecomment.
|
Mind fixing the spacing in your commit? After that, feel free to merge. |
|
Prettified and merged. |
michaelficarra
added a commit
that referenced
this pull request
Apr 29, 2013
Fix implicit calls with preceding herecomment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple fix for #2916: Use
@matchTagsto skip herecomments only after the current token has been recognized asIMPLICIT_FUNC.