Fix path separator issues in tests. #3045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mmh, are you getting failure messages? I'm not getting any in windows. |
|
|
|
I've got right now (with the changes in this PR): |
|
Indeed, I was on an outdated branch ! Thanks :). |
vendethiel
added a commit
that referenced
this pull request
Jun 22, 2013
Fix path separator issues in tests.
|
I'm still confused as to when Node is supposed to handle normalized path names, or not. Does it not do any normalization anymore? Was that only back in the old Node-just-runs-under-Cygwin days? |
|
As per the PR, on print out Node prints the OS version. $ node
> fs.stat("../bla\\hello")
> fs: missing callback Error: ENOENT, stat 'c:\Work\bla\hello' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests fail under Windows due to hardcoded *nix path separators.