bound functions do not perserve arities #3257
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added two test cases, to ensure bound functions don’t lose their arities.
|
If you know of a way to (compatibly) preserve arities in a bound function, feel free to send a patch. As far as I know, it can't be done. |
|
@jashkenas: It certainly can be done, as can be seen in #2489 and CoffeeScriptRedux's compilation. |
|
Ah, right — when we have a reference to the source of the function, of course. I was mis-remembering from the "bind" operator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using
coffee-scriptandconnect.js. I came into a problem and digged intoconnect's source code, and I find on this line, connect uses Function.length to determine the type of a handler. And then I foundcoffee-scriptfailed to perserve arities in bound functions of a class.To indicate the issue, I added two test cases. The first one passed, but the second one failed. I'll try to submit a patch later.