Fix child_process.fork patch
#3293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Preserve `options` when called without `args` * Don't use `coffee` script as `execPath` (Fixes jashkenas#2919)
jashkenas
added a commit
that referenced
this pull request
Dec 24, 2013
Fix `child_process.fork` patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2919 by simply leaving
execPathalone. (Currentlybin/coffeeis called with node'sexecOptions.)The
coffee"binary" is now used as the module with the actual.coffee-module as its first argument. This also makes the patch work on Windows (the friendly OS where executability is determined by file extension and shebangs don't exist).Also fixes
.forkcalls without an arguments array. (Currentlyoptionsis set to[])