Fix #3502: Define param variables when expansion #3791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for {name: p} in @params when param not instanceof Expansion | ||
| if p.value then o.scope.add p.value, 'var', yes | ||
| for p in @params when p not instanceof Expansion | ||
| if p.name.value then o.scope.add p.name.value, 'var', yes |
There was a problem hiding this comment.
seems weird to have a when and a single if as body
There was a problem hiding this comment.
for p in @params
if p not instanceof Expansion and p.name.value
o.scope.add p.name.value, 'var', yes?
There was a problem hiding this comment.
Or perhaps:
for p in @params
o.scope.add p.name.value, 'var', yes if p.name?.valueThere was a problem hiding this comment.
I'd go for the first (or use some kind of any)
There was a problem hiding this comment.
I already pushed a new version before you commented ...
michaelficarra
added a commit
that referenced
this pull request
Jan 14, 2015
Fix #3502: Define param variables when expansion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.